Cache download-files in Dockerfile templates by using standalone commands#848
Open
aryeila wants to merge 1 commit into
Open
Cache download-files in Dockerfile templates by using standalone commands#848aryeila wants to merge 1 commit into
aryeila wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update the three Dockerfile templates in
pkg/agentfs/examples/to use the standalonedownload-filescommands that ship inlivekit-agents@1.5.10(Python) and@livekit/agents@1.4.3(Node.js). The download step now runs beforeCOPY . ., so the layer caches across code-only changes — editing your agent no longer triggers a re-download of plugin model files.Changes
node.Dockerfile—RUN pnpm download-files(afterpnpm build, afterCOPY . .) →RUN npx livekit-agents download-files(beforeCOPY . .). Drops the requirement that the user'spackage.jsondefine adownload-filesscript.python.uv.Dockerfile—RUN uv run "{{.ProgramMain}}" download-files(afterCOPY . .) →RUN uv run --module livekit.agents download-files(beforeCOPY . .).python.pip.Dockerfile—RUN python "{{.ProgramMain}}" download-files(afterCOPY . .) →RUN python -m livekit.agents download-files(beforeCOPY . .).The new commands discover installed plugin packages (
livekit-plugins-*for Python,@livekit/agents-plugin-*for Node.js) and run theirdownload_files()step without loading the user's agent code. That's what allows the step to move ahead of the source copy.Compatibility
These templates are rendered by the CLI when scaffolding a new agent project (
lk agent init). Existing users running older SDK versions won't see this change until they regenerate. The oldagent.py download-files/node dist/agent.js download-filesforms still work in newer SDKs but emit a deprecation warning.Related PRs
This is part of a coordinated rollout across four repos. Each PR updates one slice of the same migration.
Upstream SDK changes: